../shared/fs-util.c

Bug Summary

File:	.build-ci/../shared/fs-util.c
Warning:	line 176, column 7 Potential leak of memory pointed to by 'file_path'

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple x86_64-redhat-linux-gnu -O3 -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name fs-util.c -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/__w/nvme-cli/nvme-cli/.build-ci -fcoverage-compilation-dir=/__w/nvme-cli/nvme-cli/.build-ci -resource-dir /usr/bin/../lib/clang/22 -include /__w/nvme-cli/nvme-cli/.build-ci/nvme-config.h -I shared/libshared.a.p -I shared -I ../shared -I ccan -I ../ccan -D _FILE_OFFSET_BITS=64 -D _GNU_SOURCE -U NDEBUG -internal-isystem /usr/bin/../lib/clang/22/include -internal-isystem /usr/local/include -internal-isystem /usr/bin/../lib/gcc/x86_64-redhat-linux/16/../../../../x86_64-redhat-linux/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -std=gnu11 -ferror-limit 19 -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcolor-diagnostics -vectorize-loops -vectorize-slp -analyzer-opt-analyze-headers -analyzer-output=html -faddrsig -fdwarf2-cfi-asm -o /__w/nvme-cli/nvme-cli/.build-ci/scan-results/2026-10-24-125112-639-1 -x c ../shared/fs-util.c

1// SPDX-License-Identifier: LGPL-2.1-or-later
2/*
* This file is part of nvme-cli.
* Copyright (c) 2026 Dell Technologies Inc. or its subsidiaries.
*
* Authors: Martin Belanger <martin.belanger@dell.com>
*/

9#include <dirent.h>
10#include <errno(*__errno_location ()).h>
11#include <limits.h>
12#include <stdio.h>
13#include <stdlib.h>
14#include <string.h>
15#include <sys/stat.h>
16#include <unistd.h>

18#include "cleanup-util.h"
19#include "fs-util.h"

21int shr_mkdir_p(const char *path, mode_t mode)
22{
char buf[PATH_MAX4096];
char *p;
size_t len;
int ret;

len = strlen(path);
if (len >= sizeof(buf))
return -ENAMETOOLONG36;
memcpy(buf, path, len + 1);
if (len && buf[len - 1] == '/')
buf[len - 1] = '\0';

for (p = buf + 1; *p; p++) {
if (*p != '/')
	continue;
*p = '\0';
ret = shr_mkdir(buf, mode);
*p = '/';
if (ret < 0 && ret != -EEXIST17)
	return ret;
}
ret = shr_mkdir(buf, mode);
return (ret == 0 || ret == -EEXIST17) ? 0 : ret;
46}

48int shr_mkdir_from_fname(const char *file, mode_t mode)
49{
__cleanup_free__attribute__((cleanup(shr_freep))) char *file_copy = NULL((void*)0);
char *parent;
size_t len = strlen(file);

/*
* A trailing '/' means there is no file name to strip and the path is
* a directory in full. dirname() cannot be used for it: it removes
* the trailing '/' before the last component, so "a/b/" would come
* back as "a" and leave "a/b" uncreated.
*/
if (len && file[len - 1] == '/')
return shr_mkdir_p(file, mode);

file_copy = strdup(file);
if (!file_copy)
return -ENOMEM12;

parent = shr_dirname(file_copy);
return shr_mkdir_p(parent, mode);
69}

71char *shr_basename(const char *path)
72{
char *p = (char *)strrchr(path, '/')_Generic (0 ? (path) : (void *) 1, const void *: (const char *
) (strrchr (path, '/')), default: strrchr (path, '/'));

return p ? p + 1 : (char *)path;
76}

78size_t shr_dir_prefix_len(const char *path)
79{
return (size_t)(shr_basename(path) - path);
81}

83static char *join_path(const char *dir, const char *path)
84{
char *out;
size_t len;

if (!dir)
3
←
Assuming 'dir' is null→
4
←
Taking true branch→
return strdup(path);
5
←
Memory is allocated→
if (!path || !*path)
return strdup(dir);

len = strlen(dir) + 1 + strlen(path) + 1;
out = malloc(len);
if (!out)
return NULL((void*)0);
snprintf(out, len, "%s/%s", dir, path);

return out;
100}

102int shr_rmdir_recursive(const char *path)
103{
DIR *dir;
struct dirent *entry;
char child[PATH_MAX4096];
int ret;

/*
* opendir() follows symlinks, so without this check a path that is
* itself a symlink to a directory would have its target's contents
* walked and removed instead of just the link, like "rm -rf" does.
* A missing path is not a directory either, so unlink() below runs
* for it too and reports the ENOENT that makes this a no-op.
*/
if (!shr_isdir(path))
return unlink(path) == 0 || errno(*__errno_location ()) == ENOENT2 ? 0 : -errno(*__errno_location ());

dir = opendir(path);
if (!dir)
return errno(*__errno_location ()) == ENOENT2 ? 0 : -errno(*__errno_location ());

while ((entry = readdir(dir))) {
int saved_errno;

if (!strcmp(entry->d_name, ".") || !strcmp(entry->d_name, ".."))
	continue;

if (snprintf(child, sizeof(child), "%s/%s",
	     path, entry->d_name) >= (int)sizeof(child)) {
	closedir(dir);
	return -ENAMETOOLONG36;
}

if (unlink(child) == 0 || errno(*__errno_location ()) == ENOENT2)
	continue;

/*
 * Unlinking a directory fails with EISDIR or EPERM on Linux,
 * EACCES on Windows. Any other errno means child could not be
 * removed at all, directory or not.
 */
if (errno(*__errno_location ()) != EISDIR21 && errno(*__errno_location ()) != EPERM1 && errno(*__errno_location ()) != EACCES13) {
	saved_errno = errno(*__errno_location ());
	closedir(dir);
	return -saved_errno;
}

ret = shr_rmdir_recursive(child);
if (ret < 0 && ret != -ENOENT2) {
	closedir(dir);
	return ret;
}
}

closedir(dir);

ret = shr_rmdir(path);
return (ret == 0 || ret == -ENOENT2) ? 0 : ret;
160}

162int shr_read_file(const char *dir, const char *path, long *size,
  unsigned char **out)
164{
__cleanup_free__attribute__((cleanup(shr_freep))) char *file_path = NULL((void*)0);
unsigned char *buf;
FILE *file;
long file_size;
size_t n;
int ret;

file_path = join_path(dir, path);
2
←
Calling 'join_path'→
6
←
Returned allocated memory→
if (!file_path)
7
←
Assuming 'file_path' is non-null→
8
←
Taking false branch→
return -ENOMEM12;

file = fopen(file_path, "rb");
9
←
Potential leak of memory pointed to by 'file_path'
if (!file)
return -errno(*__errno_location ());

if (fseek(file, 0, SEEK_END2) != 0 || (file_size = ftell(file)) < 0) {
ret = -errno(*__errno_location ());
goto close_file;
}
if (file_size == 0) {
ret = -ENODATA61;
goto close_file;
}
if (fseek(file, 0, SEEK_SET0) != 0) {
ret = -errno(*__errno_location ());
goto close_file;
}

buf = malloc(file_size);
if (!buf) {
ret = -ENOMEM12;
goto close_file;
}

n = fread(buf, 1, file_size, file);
if (n != (size_t)file_size) {
free(buf);
ret = -EIO5;
goto close_file;
}

*size = file_size;
*out = buf;
ret = 0;

210close_file:
fclose(file);
return ret;
213}

215int shr_read_file_as_string(const char *dir, const char *path, long *size,
	    char **out)
217{
unsigned char *raw = NULL((void*)0);
char *str;
long raw_size = 0;
int ret;

ret = shr_read_file(dir, path, &raw_size, &raw);
1
Calling 'shr_read_file'→
if (ret < 0 && ret != -ENODATA61)
return ret;

str = realloc(raw, raw_size + 1);
if (!str) {
free(raw);
return -ENOMEM12;
}
str[raw_size] = '\0';

if (size)
*size = raw_size;

*out = str;
return 0;
239}